jerqi commented on code in PR #18:
URL: https://github.com/apache/incubator-uniffle/pull/18#discussion_r913083297
##########
common/src/test/java/org/apache/uniffle/common/config/ConfigOptionTest.java:
##########
@@ -131,6 +131,20 @@ public void testListTypes() {
} catch (IllegalArgumentException illegalArgumentException) {
fail();
}
+
+ // test the empty list
+ final ConfigOption<List<String>> emptyListStringOption = ConfigOptions
+ .key("rss.key5")
+ .stringType()
+ .asList()
+ .noDefaultValue()
+ .withDescription("List config key5");
Review Comment:
If we don't set this option and call method conf.get(emptyListStringOption)
directly, what will the result be?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
