jerqi commented on issue #339:
URL: 
https://github.com/apache/incubator-uniffle/issues/339#issuecomment-1328068030

   > > > > > `rss.client.send.check.timeout.ms=600000` 
`rss.client.retry.max=100` `rss.client.retry.interval.max=10000`
   > > > > 
   > > > > 
   > > > > 100 * 10000 = 1000000 > 600000, This default values seems 
unreasonable.
   > > > 
   > > > 
   > > > But we should also solve this problem first.
   > > 
   > > 
   > > Should we reduce `rss.client.retry.max` and 
`rss.client.retry.interval.max=10000` according to write replicas?
   > 
   > I think it is ok. And i think we should remove 
`rss.client.send.check.timeout.ms`, we can just control by 
`rss.client.retry.max` and `rss.client.retry.interval.max`. Otherwise, it's too 
complex and diffcult to control.
   
   Could we check  `rss.client.send.check.timeout.ms`? If   
`rss.client.send.check.timeout.ms` is less than `rss.client.retry.max * 
rss.client.retry.interval.max`, we throw an exception.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to