+1 (binding) from me. I have checked: - Can compile from source(on Apple M1) - UT passed: `mvn package -Pspark3` - No unexpected binary files
P.S: the first ut run failed for some unknown reason, It may indicate a flaky test or just an environment issue. Since I cannot reproduce it, it shouldn’t be a blocker. > On Nov 29, 2022, at 12:20, Xun Liu <liu...@apache.org> wrote: > > +1 (binding) from me, > > I have checked the following items: > - Incubating in name > - LICENSE and NOTICE are fine > - DISCLAIMER-WIP exists > - All links are valid > - No unexpected binary files > - All ASF files have ASF headers > - Can compile from source > `mvn clean install` > > Best regards > Xun Liu > > On Tue, Nov 29, 2022 at 12:01 PM roryqi <ror...@apache.org> wrote: > >> From my side >> +1 (binding) >> >> I have checked >> * Download links, checksums and PGP signatures are valid >> * LICENSE, NOTICE and DISCLAIMER-WIP files are correct >> * No unlicensed compiled archives bundled in source archive. >> * UT passed. I use the command `mvn package -Pspark3` >> >> >> Kaijie Chen <c...@apache.org> 于2022年11月29日周二 11:16写道： >> >>> Hi everyone, >>> >>> I am calling a vote for releasing Apache Uniffle (Incubating) 0.6.1 rc2. >>> The rc1 was skipped due to missing of the project version bump. >>> >>> The git tag to be voted upon: >>> https://github.com/apache/incubator-uniffle/tree/v0.6.1-rc2 >>> >>> The git commit hash: >>> 753f7b3044f35042f5a0718127f9148db80accbb >>> >>> The source tarballs can be found at: >>> https://dist.apache.org/repos/dist/dev/incubator/uniffle/0.6.1-rc2/ >>> >>> Fingerprint of the PGP key release artifacts are signed with: >>> 3B8167D035D33A4C2D725FAA39A39E985C5EFBA4 >>> >>> My public key to verify signatures can be found in: >>> https://dist.apache.org/repos/dist/dev/incubator/uniffle/KEYS >>> >>> The vote will be open for at least 72 hours or until necessary >>> number of votes are reached. >>> >>> Please vote accordingly: >>> >>> [ ] +1 approve >>> [ ] +0 no opinion >>> [ ] -1 disapprove (and the reason) >>> >>> Starting with my +1 (non-binding): >>> >>> * Download links, checksums and PGP signatures are valid. >>> * LICENSE and NOTICE files are correct, all files have license headers if >>> necessary. >>> * No unlicensed compiled archives bundled in source archive. >>> * The source tarball matches the git tag. >>> * Build from source is successful, regular Uniffle CI passed. [1] >>> >>> Thanks, >>> Kaijie >>> >>> --- >>> [1]: https://github.com/apache/incubator-uniffle/actions/runs/3570552682 >>> >>
