Sorry, I would retract my +1 here. 

I did a double test run, seems like the integration tests failed. 
Command: `mvn test -Pspark3`
Two test failed:

[ERROR] Errors: 
[ERROR]   
DiskErrorToleranceTest.setupServers:76->IntegrationTestBase.createShuffleServer:133
 » Runtime
[ERROR]   ShuffleServerFaultToleranceTest.testReadFaultTolerance:125 » 
NullPointer
[INFO] 
[ERROR] Tests run: 65, Failures: 0, Errors: 2, Skipped: 1


Junfan, would like help to do some more investigation here?
On 2023/03/09 07:26:40 Xianjin Ye wrote:
> +1 binding, thanks Junfan
> 
> I have checked:
> 1. Download links, checksums and PGP signatures are valid
> 2. mvn package -Pspark3 ran successfully
> 3. DISCLAIMER, LICENSE, NOTICE are correct
> 4. No unlicensed compiled achives bundled in source archive.
> 
> On 2023/03/08 10:57:12 roryqi wrote:
> > For my side
> > + binding
> > I have checked that
> > 1. Download links, checksums and PGP signatures are valid.
> > 2. I run the `mvn package`, tests passed. remind that the version of maven
> > should be higher than 3.6.3. I encounter the failure when I use maven 3.6.1
> > 3. DISCLAIMER, LICENSE and NOTICE files are correct.
> > 4. All files have license headers if necessary.
> > 
> > Kaijie Chen <c...@apache.org> 于2023年3月8日周三 16:19写道:
> > 
> > > +1 (non-binding), thanks Junfan
> > >
> > > I have checked:
> > >
> > > * Download links, checksums and PGP signatures are valid.
> > > * The source tarball matches the git tag.
> > > * Source code distributions have correct names matching the current
> > > release.
> > > * Release files have the word incubating in their name.
> > > * DISCLAIMER, LICENSE and NOTICE files are correct.
> > > * All files have license headers if necessary.
> > > * No unlicensed compiled archives bundled in source archive.
> > > * Build from source with every profiles are successful.
> > >
> > > Best,
> > > Kaijie
> > >
> > > On 2023/03/08 07:43:30 Junfan Zhang wrote:
> > > > Hi Uniffle community,
> > > >
> > > > This is a call for vote to release Apache Uniffle (Incubating) 0.7.0-rc2
> > > >
> > > > Compared to 0.6.1, the most important features are as follows
> > > > 1. Better support for  spark AQE
> > > > 2. Optimization of a huge partition to improve stability of shuffle
> > > servers
> > > > 3. More bug fixes and usability improvements of K8S operator
> > > > 4. Add support of user quota management and more compression algorithms
> > > > 5. Add support for the spark data eviction mechanism of stage level
> > > > 6. Some improvement of stability and performance
> > > >
> > > > And the detailed changelog could be found in
> > > > https://github.com/apache/incubator-uniffle/compare/v0.6.1..v0.7.0-rc2
> > > >
> > > > Compared to 0.7.0-rc1, this release has the following changes
> > > > 1. Cherry pick the two flaky test fixes from the master branch
> > > > 2. Remove the unnecessary files of pom.xml.versionsBackup
> > > >
> > > > The git tag to be voted upon:
> > > >     https://github.com/apache/incubator-uniffle/tree/v0.7.0-rc2
> > > >
> > > > The git commit hash:
> > > >     6c8bfc72729a98ecc44cfd978c22365c6851e9f1
> > > >
> > > > The source tarballs can be found at:
> > > >     https://dist.apache.org/repos/dist/dev/incubator/uniffle/0.7.0-rc2/
> > > >
> > > > Fingerprint of the PGP key release artifacts are signed with:
> > > >     0CF4889DD77BDD442FAE334495A12D262CEB34D0
> > > >
> > > > My public key to verify signatures can be found in:
> > > >     https://dist.apache.org/repos/dist/dev/incubator/uniffle/KEYS
> > > >
> > > > The vote will be open for at least 72 hours or until the necessary
> > > > number of votes are reached.
> > > > Please vote accordingly:
> > > > [ ] +1 approve
> > > > [ ] +0 no opinion
> > > > [ ] -1 disapprove (and the reason)
> > > >
> > > > Checklist for release:
> > > >
> > > >
> > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> > > > Steps to validate the release:
> > > >     https://linkis.apache.org/community/how-to-verify
> > > >
> > > > Starting with my +1 (non-binding):
> > > >
> > > > * Download links, checksums and PGP signatures are valid.
> > > > * Source code distributions have correct names matching the current
> > > release.
> > > > * Release files have the word incubating in their name.
> > > > * DISCLAIMER, LICENSE and NOTICE files are correct.
> > > > * All files have license headers if necessary.
> > > > * No unlicensed compiled archives bundled in source archive.
> > > > * The source tarball matches the git tag.
> > > > * Build from source is successful, Uniffle CI passed. [1]
> > > >
> > > > Thanks,
> > > > Junfan Zhang
> > > >
> > > > ---
> > > > [1]: https://github.com/apache/incubator-uniffle/actions/runs/4361986818
> > > >
> > >
> > 
> 

Reply via email to