jerqi commented on issue #865: URL: https://github.com/apache/incubator-uniffle/issues/865#issuecomment-1546543659
> After further investigation, LocalStorageChecker is automatically enabled when using LocalStorage. Enabling via health check and configuring the LocalStorageChecker class is not required. > > Out the box it’s not obvious that LocalStorageChecker is automatically enabled, some additional logging when this class is initialised and preventing the HealthCheck from initialising LocalStorageChecker maybe valuable? > > NB: From what I can see enabled HealthChecks does not prevent the server from writing to disk. The server metric is labelled as unhealthy but this is not used. Is this intentional? I did find another bug whilst trying to limit the amount of local disk uniffle can consume. The bug is to do with the metadata disk size not being updated when events are processed. I’ll raise a separate issue for this 1. It's ok to log extra information. 2. We don't have hard limit about the disk usage. If you have interest, you can design it and contribute to Uniffle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
