awdavidson opened a new issue, #881: URL: https://github.com/apache/incubator-uniffle/issues/881
### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) ### Search before asking - [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues. ### Describe the bug `LocalStorageMeta` disk size is not being updated for all events meaning `LocalStorage.canWrite` is always true. When running a spark application, the first shuffle event will get marked as `underStorage` in `LocalStorageManager.selectStorage` however, follow events for the same shuffle and partition ID are not `setUnderStorage`. Whilst this causes no issues when writing shuffle files `SingleStorageManager.updateWriteMetrics` will only update `LocalStorageMeta` for the first event where `underStorage` is not null (all future events for the same shuffle and partition ID will be null). As the metadata disk size is not updated, the `LocalStorage.canWrite` will always return true regardless of what the actual state. In my scenario, I would like to limit the amount of disk uniffle can use, addressing this bug mean the `canWrite` will correctly reflect state and retry shuffle write when `canWrite` is false and in my case disk space is available. ### Affects Version(s) master ### Uniffle Server Log Output _No response_ ### Uniffle Engine Log Output _No response_ ### Uniffle Server Configurations _No response_ ### Uniffle Engine Configurations _No response_ ### Additional context _No response_ ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
