zhengchenyu commented on issue #986:
URL:
https://github.com/apache/incubator-uniffle/issues/986#issuecomment-1623251753
@lifeSo
That's a good idea, as only computeShuffleId use vertex id.
But just like the code show below. I check whether vertex id is -1, but the
-1 is the default value of config. If we want to move assert to
computeShuffleId, I think getInt also should move to computeShuffleId. How
about this way?
```
int sourceVertexId = this.conf.getInt(RSS_SHUFFLE_SOURCE_VERTEX_ID, -1);
int destinationVertexId =
this.conf.getInt(RSS_SHUFFLE_DESTINATION_VERTEX_ID, -1);
assert sourceVertexId != -1;
assert destinationVertexId != -1;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
