weburnit commented on pull request #156:
URL: https://github.com/apache/unomi/pull/156#issuecomment-624509845


   > Thank you so much for your contribution. I reviewed it quickly and it 
looks mostly good apart from a typo I noticed. However there are a couple 
things I'd like to request. Could you update the custom.system.properties file 
so that KAFKA configurations can also be updated via environment variables for 
Docker images ? And also if you could add a section to the manual that would be 
fantastic !
   
   Hopefully last commit solve your request! Thanks for your prompt review


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to