sergehuber commented on a change in pull request #353: URL: https://github.com/apache/unomi/pull/353#discussion_r730371512
########## File path: services/src/main/java/org/apache/unomi/services/impl/schemas/PropertyTypeKeyword.java ########## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.unomi.services.impl.schemas; + +import com.fasterxml.jackson.databind.JsonNode; +import com.networknt.schema.*; +import org.apache.unomi.api.PropertyType; +import org.apache.unomi.api.services.ProfileService; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.text.MessageFormat; +import java.util.*; + +class PropertyTypeKeyword extends AbstractKeyword { + + private static final Logger logger = LoggerFactory.getLogger(PropertyTypeKeyword.class); + + private final ProfileService profileService; + private final SchemaRegistryImpl schemaRegistry; + + private static final class PropertyTypeJsonValidator extends AbstractJsonValidator { + + String schemaPath; + JsonNode schemaNode; + JsonSchema parentSchema; + ValidationContext validationContext; + ProfileService profileService; + SchemaRegistryImpl schemaRegistry; + + public PropertyTypeJsonValidator(String keyword, String schemaPath, JsonNode schemaNode, JsonSchema parentSchema, ValidationContext validationContext, ProfileService profileService, SchemaRegistryImpl schemaRegistry) { + super(keyword); + this.schemaPath = schemaPath; + this.schemaNode = schemaNode; + this.parentSchema = parentSchema; + this.validationContext = validationContext; + this.profileService = profileService; + this.schemaRegistry = schemaRegistry; + } + + @Override + public Set<ValidationMessage> validate(JsonNode node, JsonNode rootNode, String at) { + Set<ValidationMessage> validationMessages = new HashSet<>(); + Iterator<String> fieldNames = node.fieldNames(); + while (fieldNames.hasNext()) { + String fieldName = fieldNames.next(); + PropertyType propertyType = getPropertyType(fieldName); + if (propertyType == null) { + validationMessages.add(buildValidationMessage(CustomErrorMessageType.of("property-not-found", new MessageFormat("{0} : Couldn''t find property type with id={1}")), at, fieldName)); + } else { + // @todo further validation, if it can be used in this context (event, profile, session) + String valueTypeId = propertyType.getValueTypeId(); + JsonSchema jsonSchema = schemaRegistry.getJsonSchema("https://unomi.apache.org/schemas/json/values/"; + valueTypeId + ".json"); + if (jsonSchema == null) { + validationMessages.add(buildValidationMessage(CustomErrorMessageType.of("value-schema-not-found", new MessageFormat("{0} : Couldn''t find schema type with id={1}")), at, "https://unomi.apache.org/schemas/json/values/"; + valueTypeId + ".json")); Review comment: This is actually not a typo, MessageFormat requires single quotes to be escaped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
