sergehuber commented on a change in pull request #368:
URL: https://github.com/apache/unomi/pull/368#discussion_r784117695
##########
File path:
rest/src/main/java/org/apache/unomi/rest/endpoints/ContextJsonEndpoint.java
##########
@@ -378,6 +372,26 @@ private Changes handleRequest(ContextRequest
contextRequest, Session session, Pr
Changes changes =
restServiceUtils.handleEvents(contextRequest.getEvents(), session, profile,
request, response, timestamp);
data.setProcessedEvents(changes.getProcessedItems());
+ List<PersonalizationService.PersonalizedContent> filterNodes =
contextRequest.getFilters();
+ if (filterNodes != null) {
+ data.setFilteringResults(new HashMap<>());
+ for (PersonalizationService.PersonalizedContent
personalizedContent : sanitizePersonalizedContentObjects(filterNodes)) {
+ data.getFilteringResults()
+ .put(personalizedContent.getId(),
personalizationService.filter(profile, session, personalizedContent));
+ }
+ }
+
+ List<PersonalizationService.PersonalizationRequest> personalizations =
contextRequest.getPersonalizations();
+ if (personalizations != null) {
+ data.setPersonalizations(new HashMap<>());
+ for (PersonalizationService.PersonalizationRequest personalization
: sanitizePersonalizations(personalizations)) {
+ PersonalizationResult personalizationResult =
personalizationService.personalizeList(profile, session, personalization);
+ changes.setChangeType(changes.getChangeType() |
personalizationResult.getChangeType());
+ data.getPersonalizations()
+ .put(personalization.getId(),
personalizationResult.getContentIds());
+ }
+ }
+
Review comment:
I like this suggestion. Should we merge this first and then rewrite it
or should we change directly in the same PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
