jkevan commented on code in PR #428:
URL: https://github.com/apache/unomi/pull/428#discussion_r886399954
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/customitems/page/properties/pageInfo.json:
##########
@@ -0,0 +1,58 @@
+{
+ "$id":
"https://unomi.apache.org/schemas/json/customitems/page/properties/pageInfo/1-0-0",
+ "$schema": "https://json-schema.org/draft/2019-09/schema",
+ "self": {
+ "vendor": "org.apache.unomi",
+ "name": "pageInfo",
+ "format": "jsonschema",
+ "version": "1-0-0"
+ },
Review Comment:
I wonder if all the page view related schemas should not be part of
jExperience instead of Unomi core.
Since this event is triggered and sent by jExp. also jExp does contains
specific rules on the page view event like:
incrementPageViewCount.
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/customitems/site.json:
##########
@@ -2,7 +2,7 @@
"$id": "https://unomi.apache.org/schemas/json/customitems/site/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
"self":{
- "vendor":"org.apache.unomi",
+ "vendor":"The Apache Software Foundation",
Review Comment:
I think this JSON schema would be better in JExp
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/values/boolean.json:
##########
@@ -1,6 +1,13 @@
{
"$id": "https://unomi.apache.org/schemas/json/values/boolean/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
+ "self":{
+ "vendor":"The Apache Software Foundation",
+ "target" : "values",
+ "name": "boolean",
+ "format":"jsonschema",
+ "version":"1-0-0"
+ },
Review Comment:
do we still need this schemas on values type ?
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/metadata.json:
##########
@@ -1,6 +1,12 @@
{
"$id": "https://unomi.apache.org/schemas/json/metadata/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
+ "self":{
+ "vendor":"The Apache Software Foundation",
+ "name": "metadata",
+ "format":"jsonschema",
+ "version":"1-0-0"
+ },
Review Comment:
This JSON Schema is not requried and should be remove.
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/events/view.json:
##########
@@ -2,7 +2,7 @@
"$id": "https://unomi.apache.org/schemas/json/events/view/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
"self":{
- "vendor":"org.apache.unomi",
+ "vendor":"The Apache Software Foundation",
Review Comment:
Could be part of jExperience schemas ?
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/events/updateProperties.json:
##########
@@ -2,7 +2,7 @@
"$id": "https://unomi.apache.org/schemas/json/events/updateProperties/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
"self":{
- "vendor":"org.apache.unomi",
+ "vendor":"The Apache Software Foundation",
Review Comment:
May be we could add a comment on this schema to explain why it is open.
Because of thirdparty server key check.
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/values/email.json:
##########
@@ -1,6 +1,13 @@
{
"$id": "https://unomi.apache.org/schemas/json/values/email/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
+ "self":{
+ "vendor":"The Apache Software Foundation",
+ "target" : "values",
+ "name": "email",
+ "format":"jsonschema",
+ "version":"1-0-0"
+ },
Review Comment:
do we still need this schemas on values type ?
##########
extensions/web-tracker/wab/src/main/resources/META-INF/cxs/schemas/identify/properties.json:
##########
@@ -0,0 +1,24 @@
+{
+ "$id":
"https://unomi.apache.org/schemas/json/events/identify/properties/1-0-0",
+ "$schema": "https://json-schema.org/draft/2019-09/schema",
+ "self": {
+ "vendor": "org.apache.unomi",
+ "target": "events",
+ "name": "identifyProperties",
+ "format": "jsonschema",
+ "version": "1-0-0"
+ },
+ "title": "IdentifyProperties",
+ "type": "object",
+ "properties": {
+ "nickname": {
+ "type": "string"
+ },
+ "favoriteCompiler": {
+ "type": "string"
+ },
+ "industry": {
+ "type": "string"
+ }
+ }
Review Comment:
Careful, this schema doesn't contains "unevaluatedProperty:false", so it
could produce mapping explosion
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/events/form.json:
##########
@@ -2,7 +2,7 @@
"$id": "https://unomi.apache.org/schemas/json/events/form/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
"self":{
- "vendor":"org.apache.unomi",
+ "vendor":"The Apache Software Foundation",
Review Comment:
I think this JSON schema would be better in JExp
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/events/goal.json:
##########
@@ -2,7 +2,7 @@
"$id": "https://unomi.apache.org/schemas/json/events/goal/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
"self":{
- "vendor":"org.apache.unomi",
+ "vendor":"The Apache Software Foundation",
Review Comment:
Goal event are triggered by the system, I dont think we want this event to
be open to public event for security reason I think we should get rid of it.
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/values/integer.json:
##########
@@ -1,6 +1,13 @@
{
"$id": "https://unomi.apache.org/schemas/json/values/integer/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
+ "self":{
+ "vendor":"The Apache Software Foundation",
+ "target" : "values",
+ "name": "integer",
+ "format":"jsonschema",
+ "version":"1-0-0"
+ },
Review Comment:
do we still need this schemas on values type ?
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/customitems/site.json:
##########
@@ -15,6 +15,5 @@
"$ref": "https://unomi.apache.org/schemas/json/customitem/1-0-0"
Review Comment:
I think this object is not a custom item
##########
extensions/web-tracker/wab/src/main/resources/META-INF/cxs/schemas/articleCompleted/properties.json:
##########
@@ -0,0 +1,22 @@
+{
+ "$id":
"https://unomi.apache.org/schemas/json/events/articleCompleted/properties/1-0-0",
+ "$schema": "https://json-schema.org/draft/2019-09/schema",
+ "self": {
+ "vendor": "org.apache.unomi",
+ "target": "events",
+ "name": "articleCompletedProperties",
+ "format": "jsonschema",
+ "version": "1-0-0"
+ },
+ "title": "ArticleCompletedProperties",
+ "type": "object",
+ "properties": {
+ "title": {
+ "type": "string"
+ },
+ "course": {
+ "type": "string"
+ }
+ }
+}
Review Comment:
Careful, this schema doesn't contains "unevaluatedProperty:false", so it
could produce mapping explosion
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/profile.json:
##########
@@ -1,6 +1,12 @@
{
"$id": "https://unomi.apache.org/schemas/json/profile/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
+ "self":{
+ "vendor":"The Apache Software Foundation",
+ "name": "profile",
+ "format":"jsonschema",
+ "version":"1-0-0"
+ },
Review Comment:
Do we still need this schema ? if not we can remove it.
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/values/date.json:
##########
@@ -1,6 +1,13 @@
{
"$id": "https://unomi.apache.org/schemas/json/values/date/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
+ "self":{
+ "vendor":"The Apache Software Foundation",
+ "target" : "values",
+ "name": "date",
+ "format":"jsonschema",
+ "version":"1-0-0"
+ },
Review Comment:
do we still need this schemas on values type ?
##########
extensions/web-tracker/wab/src/main/resources/META-INF/cxs/schemas/articleCompleted.json:
##########
@@ -2,23 +2,18 @@
"$id": "https://unomi.apache.org/schemas/json/events/articleCompleted/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
"self":{
- "vendor":"org.apache.unomi",
+ "vendor":"The Apache Software Foundation",
Review Comment:
Careful, this schema doesn't contains "unevaluatedProperty:false", so it
could produce mapping explosion
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/customitem.json:
##########
@@ -1,6 +1,12 @@
{
"$id": "https://unomi.apache.org/schemas/json/customitem/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
+ "self":{
+ "vendor":"The Apache Software Foundation",
+ "name": "customItem",
+ "format":"jsonschema",
+ "version":"1-0-0"
+ },
Review Comment:
Not sure this schema is still necessary, I dont see why event should use
customItem for now.
##########
extensions/web-tracker/wab/src/main/resources/META-INF/cxs/schemas/identify.json:
##########
@@ -2,7 +2,7 @@
"$id": "https://unomi.apache.org/schemas/json/events/identify/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
"self":{
- "vendor":"org.apache.unomi",
+ "vendor":"The Apache Software Foundation",
Review Comment:
Careful, this schema doesn't contains "unevaluatedProperty:false", so it
could produce mapping explosion
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/conditiontype.json:
##########
@@ -1,6 +1,12 @@
{
"$id": "https://unomi.apache.org/schemas/json/conditiontype/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
+ "self":{
+ "vendor":"The Apache Software Foundation",
+ "name": "conditionType",
+ "format":"jsonschema",
+ "version":"1-0-0"
+ },
Review Comment:
This schema doesn't seem's to be used. We could remove it ?
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/customitems/page.json:
##########
@@ -16,58 +16,9 @@
}
],
Review Comment:
I think we should get rid of the allOf ref on customitem here, the page is
not really a custom item since it is not indexed in a separate own index as a
dedicated Item.
Page is just a object of the event targets/sources.
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/events/modifyConsent.json:
##########
@@ -13,18 +13,14 @@
"allOf": [{ "$ref": "https://unomi.apache.org/schemas/json/event/1-0-0" }],
"properties" : {
"properties" : {
- "type" : "object",
- "properties" : {
- "consent" : {
- "$ref" : "https://unomi.apache.org/schemas/json/consent/1-0-0"
- }
- }
+ "$ref" :
"https://unomi.apache.org/schemas/json/events/modifyConsent/properties/1-0-0"
},
"source" : {
"$ref" : "https://unomi.apache.org/schemas/json/customitems/page/1-0-0"
},
Review Comment:
Does the modify consent event really have a page as source ?
For me it would be better to have modifyConsent/target json schema
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/customitems/page/properties/attributes.json:
##########
@@ -0,0 +1,15 @@
+{
+ "$id":
"https://unomi.apache.org/schemas/json/customitems/page/properties/attributes/1-0-0",
Review Comment:
I think this JSON schema would be better in JExp
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/metadataitem.json:
##########
@@ -1,6 +1,12 @@
{
"$id": "https://unomi.apache.org/schemas/json/metadataitem/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
+ "self":{
+ "vendor":"The Apache Software Foundation",
+ "name": "metadataItem",
+ "format":"jsonschema",
+ "version":"1-0-0"
+ },
Review Comment:
This JSON Schema is not required and should be removed.
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/goal.json:
##########
@@ -1,6 +1,12 @@
{
"$id": "https://unomi.apache.org/schemas/json/goal/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
+ "self":{
+ "vendor":"The Apache Software Foundation",
+ "name": "goal",
+ "format":"jsonschema",
+ "version":"1-0-0"
+ },
Review Comment:
This JSON Schema is not required and should be remove.
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/values/set.json:
##########
@@ -1,6 +1,13 @@
{
"$id": "https://unomi.apache.org/schemas/json/values/set/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
+ "self":{
+ "vendor":"The Apache Software Foundation",
+ "target" : "values",
+ "name": "set",
+ "format":"jsonschema",
+ "version":"1-0-0"
+ },
Review Comment:
do we still need this schemas on values type ?
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/customitems/page/properties.json:
##########
@@ -0,0 +1,27 @@
+{
+ "$id":
"https://unomi.apache.org/schemas/json/customitems/page/properties/1-0-0",
Review Comment:
I think this JSON schema would be better in JExp
##########
extensions/web-tracker/wab/src/main/resources/META-INF/cxs/schemas/identify.json:
##########
@@ -13,12 +13,7 @@
"allOf": [{ "$ref": "https://unomi.apache.org/schemas/json/event/1-0-0" }],
"properties" : {
"properties" : {
- "type" : "object",
- "properties" : {
- "consent" : {
- "$ref" : "https://unomi.apache.org/schemas/json/consent/1-0-0"
- }
- }
+ "$ref" :
"https://unomi.apache.org/schemas/json/events/identify/properties/1-0-0"
},
"source" : {
"$ref" : "https://unomi.apache.org/schemas/json/customitems/page/1-0-0"
Review Comment:
Does this event should not have his own JSON Schemas for the target/source
object ?
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/values/long.json:
##########
@@ -1,6 +1,13 @@
{
"$id": "https://unomi.apache.org/schemas/json/values/long/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
+ "self":{
+ "vendor":"The Apache Software Foundation",
+ "target" : "values",
+ "name": "long",
+ "format":"jsonschema",
+ "version":"1-0-0"
+ },
Review Comment:
do we still need this schemas on values type ?
##########
extensions/web-tracker/wab/src/main/resources/META-INF/cxs/schemas/articleCompleted.json:
##########
@@ -2,23 +2,18 @@
"$id": "https://unomi.apache.org/schemas/json/events/articleCompleted/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
"self":{
- "vendor":"org.apache.unomi",
+ "vendor":"The Apache Software Foundation",
"target" : "events",
"name": "articleCompleted",
"format":"jsonschema",
"version":"1-0-0"
},
- "title": "AnonimyzeProfileEvent",
+ "title": "ArticleCompletedEvent",
"type": "object",
"allOf": [{ "$ref": "https://unomi.apache.org/schemas/json/event/1-0-0" }],
"properties" : {
"properties" : {
- "type" : "object",
- "properties" : {
- "consent" : {
- "$ref" : "https://unomi.apache.org/schemas/json/consent/1-0-0"
- }
- }
+ "$ref" :
"https://unomi.apache.org/schemas/json/events/articleCompleted/properties/1-0-0"
},
"source" : {
"$ref" : "https://unomi.apache.org/schemas/json/customitems/page/1-0-0"
Review Comment:
May this event should have his own source/target object JSON Schemas, dont
see why it should use customitem/1-0-0 as source for example.
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/values/string.json:
##########
@@ -1,6 +1,13 @@
{
"$id": "https://unomi.apache.org/schemas/json/values/string/1-0-0",
"$schema": "https://json-schema.org/draft/2019-09/schema",
+ "self":{
+ "vendor":"The Apache Software Foundation",
+ "target" : "values",
+ "name": "string",
+ "format":"jsonschema",
+ "version":"1-0-0"
+ },
Review Comment:
do we still need this schemas on values type ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]