jsinovassin commented on code in PR #432:
URL: https://github.com/apache/unomi/pull/432#discussion_r888780615
##########
lifecycle-watcher/src/main/java/org/apache/unomi/lifecycle/BundleWatcherImpl.java:
##########
@@ -223,50 +266,93 @@ private void displayLogsForInactiveServices() {
});
}
+ private void fillFeaturesToInstall() {
+ String installGraphQLFeature =
bundleContext.getProperty("org.apache.unomi.graphql.feature.activated");
+ boolean graphQLToInstall =
StringUtils.isNotBlank(installGraphQLFeature) &&
installGraphQLFeature.equals("true");
+ if (graphQLToInstall) {
+ featuresToInstall.add(CDP_GRAPHQL_FEATURE);
+
requiredBundlesFromFeatures.put("org.apache.unomi.cdp-graphql-api-impl", false);
+
requiredBundlesFromFeatures.put("org.apache.unomi.graphql-playground", false);
+ }
+ }
+
+ public boolean shouldInstallAdditionalFeatures() {
+ return !featuresToInstall.isEmpty();
+ }
Review Comment:
I can't because I have to wait that Unomi is started
##########
lifecycle-watcher/src/main/java/org/apache/unomi/lifecycle/BundleWatcherImpl.java:
##########
@@ -223,50 +266,93 @@ private void displayLogsForInactiveServices() {
});
}
+ private void fillFeaturesToInstall() {
+ String installGraphQLFeature =
bundleContext.getProperty("org.apache.unomi.graphql.feature.activated");
+ boolean graphQLToInstall =
StringUtils.isNotBlank(installGraphQLFeature) &&
installGraphQLFeature.equals("true");
+ if (graphQLToInstall) {
+ featuresToInstall.add(CDP_GRAPHQL_FEATURE);
+
requiredBundlesFromFeatures.put("org.apache.unomi.cdp-graphql-api-impl", false);
+
requiredBundlesFromFeatures.put("org.apache.unomi.graphql-playground", false);
+ }
+ }
+
+ public boolean shouldInstallAdditionalFeatures() {
+ return !featuresToInstall.isEmpty();
+ }
Review Comment:
I can't because I have to wait that Unomi is started before installing the
features
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
