[ 
https://issues.apache.org/jira/browse/UNOMI-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551692#comment-17551692
 ] 

Kevan Jahanshahi commented on UNOMI-586:
----------------------------------------

Segment condition have been done for: 
https://issues.apache.org/jira/browse/UNOMI-584

also the object mapping alone is not enough it should be couple with: 
[https://www.elastic.co/guide/en/elasticsearch/reference/7.17/enabled.html]

That's what have been done in commit: 
[https://github.com/apache/unomi/pull/434/commits/a4b22a8083ccbc548df228a52699c4aee42fee8f]

For Segment condition.

Error during tests execution showed this kind of errors when saving a segment:
{code:java}
2022-06-08T17:19:53,795 | ERROR | qtp1039341433-129 | 
ElasticSearchPersistenceServiceImpl | 233 - 
org.apache.unomi.persistence-elasticsearch-core - 2.0.0.SNAPSHOT |  Error while 
executing in class loader 
org.elasticsearch.ElasticsearchStatusException: Elasticsearch exception 
[type=illegal_argument_exception, reason=mapper 
[condition.parameterValues.subConditions.parameterValues.subConditions.parameterValues.subConditions.parameterValues.subConditions.parameterValues.propertyValueInteger]
 cannot be changed from type [float] to [long]] {code}
 

> Use mapping object for not searched documents.
> ----------------------------------------------
>
>                 Key: UNOMI-586
>                 URL: https://issues.apache.org/jira/browse/UNOMI-586
>             Project: Apache Unomi
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: David Griffon
>            Priority: Major
>
> Currently almost all documents in ES are mapped using a dynamic mapping. This 
> also for documents that are not queried like:
> - rules
> - conditions 
> - goals definition
> - patches
> - segments
> ...
> This task is to:
> - identify the objects that are not used in query
> - for all these objects, change the mapping to use {{object}} instead of 
> dynamic mapping
> Note that this can lead to issue, as a dynamic mapping is done on rules for 
> example, it is not possible to change the type of a field in any condition
> Another limitation of the mapping is the max depth of the mapping, as the 
> conditions can be nested, if one create more than 7 nested condition, it 
> reaches that limit.
> See 
> https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-settings-limit.html
>  for more detail



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to