jkevan commented on code in PR #458: URL: https://github.com/apache/unomi/pull/458#discussion_r916605930
########## tools/shell-commands/src/main/java/org/apache/unomi/shell/migration/Migration.java: ########## @@ -19,41 +19,23 @@ import org.apache.http.impl.client.CloseableHttpClient; import org.apache.karaf.shell.api.console.Session; import org.osgi.framework.BundleContext; -import org.osgi.framework.Version; import java.io.IOException; +import java.util.Map; /** - * This interface must be implemented if you create a new migration class * @author dgaillard + * @deprecated do groovy script for implementing new migrations Review Comment: Thx I will update it ########## tools/shell-commands/src/main/java/org/apache/unomi/shell/migration/MigrateScript.java: ########## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.unomi.shell.migration; + +import groovy.lang.Script; +import org.apache.commons.io.IOUtils; +import org.apache.commons.lang3.builder.EqualsBuilder; +import org.apache.commons.lang3.builder.HashCodeBuilder; +import org.osgi.framework.Bundle; +import org.osgi.framework.Version; + +import java.io.IOException; +import java.net.URL; + +public class MigrateScript implements Comparable<MigrateScript> { Review Comment: Thx I will update it ########## tools/shell-commands/src/main/java/org/apache/unomi/shell/migration/impl/MigrationTo122.java: ########## @@ -23,10 +23,10 @@ import org.apache.unomi.shell.migration.utils.HttpRequestException; import org.apache.unomi.shell.migration.utils.HttpUtils; import org.osgi.framework.BundleContext; -import org.osgi.framework.Version; import org.osgi.service.component.annotations.Component; import java.io.IOException; +import java.util.Map; @Component Review Comment: Thx I will update it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
