Fgerthoffert commented on code in PR #494: URL: https://github.com/apache/unomi/pull/494#discussion_r964149830
########## manual/src/main/asciidoc/whats-new.adoc: ########## @@ -51,26 +51,85 @@ More details about JSON Schemas implementation are available in the <<JSON schem The introduction of JSON schema required us to modify Apache Unomi data model, One of the key differences is the removal of open maps. -For example, the following event model in Apache Unomi 1.x: +The properties field in the events objects provided by unomi are now restricted by JSON schema. +It's not possible to add value in this property without adding the JSON schema which allows to add the properties. Review Comment: ``` ...now restricted by JSON schema. This means object properties must be declared in a JSON schema for an event to be accapted. ``` Instead of `It's not possible[...]add the properties.` ########## manual/src/main/asciidoc/whats-new.adoc: ########## @@ -51,26 +51,85 @@ More details about JSON Schemas implementation are available in the <<JSON schem The introduction of JSON schema required us to modify Apache Unomi data model, One of the key differences is the removal of open maps. -For example, the following event model in Apache Unomi 1.x: +The properties field in the events objects provided by unomi are now restricted by JSON schema. +It's not possible to add value in this property without adding the JSON schema which allows to add the properties. + +If there is dynamic properties that you want to add to the event, you should use the new property of the event named flattenedProperties. Review Comment: You should rephrase a bit this paragraph to introduce `flattenedProperties` before instructing to use it. ``` A new property, flattenedProperties has been introduced to... this property is ... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
