jkevan commented on code in PR #4: URL: https://github.com/apache/unomi-tracker/pull/4#discussion_r966881241
########## dist/apache-unomi-tracker.cjs.js: ########## @@ -0,0 +1,1571 @@ +'use strict'; Review Comment: And minified process should be done by the projects using the library directly, most of them are using bundler (WebPack, rollup, etc) and are already managing minification on there side. When it come to have a real JavaScript library, minification should not be done on the library directly. Our target at this point is not the browser usage directly, devs will need to package this lib in their own bundle system. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
