This is an automated email from the ASF dual-hosted git repository.
jkevan pushed a commit to branch unomi-1.x
in repository https://gitbox.apache.org/repos/asf/unomi.git
The following commit(s) were added to refs/heads/unomi-1.x by this push:
new 40c419d15 UNOMI-689: avoid load(null) to crash Exceptions (#577)
40c419d15 is described below
commit 40c419d155c6369c2fb9b9ab96e79af4cdcf1f05
Author: kevan Jahanshahi <[email protected]>
AuthorDate: Fri Feb 10 09:30:57 2023 +0100
UNOMI-689: avoid load(null) to crash Exceptions (#577)
---
.../elasticsearch/ElasticSearchPersistenceServiceImpl.java | 4 ++++
1 file changed, 4 insertions(+)
diff --git
a/persistence-elasticsearch/core/src/main/java/org/apache/unomi/persistence/elasticsearch/ElasticSearchPersistenceServiceImpl.java
b/persistence-elasticsearch/core/src/main/java/org/apache/unomi/persistence/elasticsearch/ElasticSearchPersistenceServiceImpl.java
index ff1b90e22..80f333cdf 100644
---
a/persistence-elasticsearch/core/src/main/java/org/apache/unomi/persistence/elasticsearch/ElasticSearchPersistenceServiceImpl.java
+++
b/persistence-elasticsearch/core/src/main/java/org/apache/unomi/persistence/elasticsearch/ElasticSearchPersistenceServiceImpl.java
@@ -737,6 +737,10 @@ public class ElasticSearchPersistenceServiceImpl
implements PersistenceService,
@Override
public <T extends Item> T load(final String itemId, final Date dateHint,
final Class<T> clazz) {
+ if (StringUtils.isEmpty(itemId)) {
+ return null;
+ }
+
return new InClassLoaderExecute<T>(metricsService,
this.getClass().getName() + ".loadItem", this.bundleContext,
this.fatalIllegalStateErrors, throwExceptions) {
protected T execute(Object... args) throws Exception {
try {