jsinovassin commented on code in PR #666:
URL: https://github.com/apache/unomi/pull/666#discussion_r1624123021
##########
itests/src/test/java/org/apache/unomi/itests/migration/Migrate16xTo220IT.java:
##########
@@ -155,23 +156,23 @@ private void checkForMappingUpdates() throws IOException {
/**
* Data set contains a form event (id:
7b55b4fd-5ff0-4a85-9dc4-ffde322a1de6) with this data:
* {
- * "properties": {
Review Comment:
It would be more readable if we keep the indent in this comment.
##########
tools/shell-commands/src/main/resources/requestBody/2.0.0/event_migrate.painless:
##########
@@ -18,7 +18,7 @@
/* Handle login events */
if ('login' == ctx._source.eventType) {
/* Look for empty scope */
- if (ctx._source.scope == '') {
+ if (ctx._source.scope == '' || ctx._source.scope == null) {
Review Comment:
It would work for user who are still in a using Unomi < 2.0.0 but for users
who are already in version 2.0.0, this migration script will not be executed.
It would be better to have another script which will be executed in 2.5.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
