GauBen opened a new pull request, #21:
URL: https://github.com/apache/unomi-tracker/pull/21
**Please** following this checklist to help us incorporate your contribution
quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/UNOMI) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without pulling in other changes.
- [ ] Format the pull request title like `[UNOMI-XXX] - Title of the pull
request`
- [ ] Provide tests for your changes, especially if you are changing the
behavior of existing code or adding
significant new parts of code.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
Copy the description to the related JIRA issue
- [ ] Run `yarn test` to make sure basic checks pass. A more thorough check
will be
performed on your pull request automatically.
Trivial changes like typos do not require a JIRA issue (javadoc, project
build changes, small doc changes, comments...).
If this is your first contribution, you have to read the [Contribution
Guidelines](https://unomi.apache.org/contribute.html)
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf)
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the [Apache License
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
Hello! This library should expose TypeScript types, and this is what this PR
does:
- Add TypeScript dev dependency, tsconfig.json file
- Add `tsc` to the build script (with `|| true` as the JS code contains of
lot of type issues)
- Remove intermediary `index.js` file, as it affected the type quality
- Update dist files (are you sure they should be versioned?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
