sergehuber commented on PR #759: URL: https://github.com/apache/unomi/pull/759#issuecomment-4573212008
Following an additional local review pass, a few more things have been cleaned up in the latest commit: - **`stop-opensearch` execution added** — the OpenSearch profile was missing a `post-integration-test` stop, so the container would keep running after a test run. Both profiles now stop their container symmetrically after tests. - **`--keep-container` flag** — to make up for losing the "container stays around after a failure" behaviour, both profiles now support `it.keepContainer=true` (Maven) / `--keep-container` (build.sh). When set, the post-test stop is skipped so you can inspect logs or run queries manually. The pre-test cleanup still runs unconditionally on the next run. - **`ignoreRunningContainers` on the pre-start cleanup** — added to both profiles so the `stop`/`remove` at the start of a run doesn't fail when no leftover container exists (e.g. first-ever run or after a manual cleanup). - **`-Dcluster.default.index.settings.number_of_replicas=0` removed from OpenSearch too** — the same JVM-property mistake noted by the Copilot review was also present in `OPENSEARCH_JAVA_OPTS`; cleaned up there as well. - **`GraphQLListIT` polling resilience** — the catch block and null-guard in the `keepTrying` supplier were removed in an earlier commit; restored them to prevent a transient HTTP error from aborting the poll loop immediately instead of retrying. - **`docker-maven-plugin` version pin** — centralised in root `pluginManagement`; the Elasticsearch profile inherits it from there. (The OpenSearch profile still has an explicit `<version>` — leaving that as a follow-up.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
