sergehuber commented on code in PR #760: URL: https://github.com/apache/unomi/pull/760#discussion_r3362972679
########## api/src/main/java/org/apache/unomi/api/security/SecurityService.java: ########## @@ -0,0 +1,234 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.unomi.api.security; + +import javax.security.auth.Subject; +import java.security.Principal; +import java.util.Set; + +/** + * A service to manage security-related operations in Apache Unomi. + * This service provides comprehensive security management including: + * - Subject management (authentication and authorization) + * - Role-based access control (RBAC) + * - Tenant isolation and access control + * - Operation validation + * - System and privileged operations + * - Encryption key management + */ +public interface SecurityService { + /** The system tenant identifier used for system-wide operations */ + String SYSTEM_TENANT = "SYSTEM_TENANT"; Review Comment: Fixed in commit 9eefd885: corrected to "system". This was causing subtle context resolution failures across services that used TenantService.SYSTEM_TENANT alongside SecurityService.SYSTEM_TENANT — they were comparing different strings for what should be the same concept. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
