sergehuber commented on code in PR #770:
URL: https://github.com/apache/unomi/pull/770#discussion_r3369849905


##########
itests/lib/it-run-karaf.sh:
##########
@@ -0,0 +1,748 @@
+# Karaf log triage for archive-it-run.sh (supports log4j2 rollover: karaf.log, 
karaf.log.1, …).
+# Expects archive hooks: target_path, staging_path, log_staged_file, 
register_staged_file,
+# mark_included, ui_spinner_run, ui_detail, line_matches_expected_pattern, 
PATTERNS_FILE,
+# TARGET_DIR, FULL_KARAF, MANIFEST.

Review Comment:
   Fixed. The file now carries the standard ASF license header. It has also 
been reorganised into `itests/lib/it-run-karaf.sh`.



##########
itests/lib/it-run-context.sh:
##########
@@ -0,0 +1,139 @@
+# Run context and manifest assembly for archive-it-run.sh.
+# Expects archive hooks: target_path, staging_path, log_staged_file, 
mark_included,
+# and globals: SCRIPT_DIR, REPO_ROOT, TARGET_DIR, MANIFEST, OUTPUT, 
RUN_MESSAGE,
+# RUN_ID, FULL_KARAF, CREATE_TAR, RUN_CONTEXT_REL, RUN_TRACE_FILE.

Review Comment:
   Fixed. The file now carries the standard ASF license header. It has also 
been reorganised into `itests/lib/it-run-context.sh`.



##########
itests/lib/it-run-compare.sh:
##########
@@ -0,0 +1,301 @@
+# Cross-run comparison engine (sourced by compare-it-runs.sh and 
archive-it-run.sh).
+

Review Comment:
   Fixed. The file now carries the standard ASF license header. It has also 
been reorganised into `itests/lib/it-run-compare.sh`.



##########
itests/it-run-bootstrap.sh:
##########
@@ -0,0 +1,18 @@
+# Source all IT run tooling modules (sourced, not executed).
+

Review Comment:
   Fixed. The file now carries the standard ASF license header. It has also 
been reorganised into `itests/lib/it-run-bootstrap.sh`.



##########
itests/llm-it-run-analysis-guide.md:
##########
@@ -0,0 +1,109 @@
+# LLM analysis guide — Apache Unomi integration test archive

Review Comment:
   Fixed. The guide now opens with the standard ASF license header in an HTML 
comment block, consistent with how other Markdown files in the project carry it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to