This is an automated email from the ASF dual-hosted git repository.
sergehuber pushed a change to branch UNOMI-883-condition-validation
in repository https://gitbox.apache.org/repos/asf/unomi.git
from bccb264fe UNOMI-883: Fix issues raised in PR #773 review
add 257f9edb0 UNOMI-883: Add condition evaluator unit tests and clean up
remaining review findings
No new revisions were added by this update.
Summary of changes:
.../org/apache/unomi/api/utils/ParserHelper.java | 7 +-
.../apache/unomi/api/utils/ParserHelperTest.java | 45 +++++-
plugins/baseplugin/pom.xml | 5 +
.../conditions/BooleanConditionEvaluatorTest.java | 170 +++++++++++++++++++++
.../conditions/IdsConditionEvaluatorTest.java | 111 ++++++++++++++
.../services/impl/TypeResolutionServiceImpl.java | 22 ++-
.../services/impl/segments/SegmentServiceImpl.java | 38 ++---
.../validation/ConditionValidationServiceImpl.java | 19 ++-
.../validators/NumericValueTypeValidator.java | 44 ------
.../impl/TypeResolutionServiceImplTest.java | 67 +++++++-
.../ConditionValidationServiceImplTest.java | 1 +
11 files changed, 438 insertions(+), 91 deletions(-)
create mode 100644
plugins/baseplugin/src/test/java/org/apache/unomi/plugins/baseplugin/conditions/BooleanConditionEvaluatorTest.java
create mode 100644
plugins/baseplugin/src/test/java/org/apache/unomi/plugins/baseplugin/conditions/IdsConditionEvaluatorTest.java
delete mode 100644
services/src/main/java/org/apache/unomi/services/impl/validation/validators/NumericValueTypeValidator.java
