Copilot commented on code in PR #42:
URL: https://github.com/apache/unomi-site/pull/42#discussion_r3425966065
##########
src/main/webapp/_layouts/default.html:
##########
@@ -318,12 +318,13 @@
<div class="col-6 col-md-3">
<div class="text-uppercase fw-semibold mb-3 text-white-50
small" role="heading" aria-level="2">Apache</div>
<ul class="list-unstyled small">
+ <li class="mb-2"><a href="https://www.apache.org/";
target="_blank" rel="noopener" class="footer-link">Foundation</a></li>
<li class="mb-2"><a
href="https://www.apache.org/licenses/"; target="_blank" rel="noopener"
class="footer-link">License</a></li>
<li class="mb-2"><a
href="https://www.apache.org/security/"; target="_blank" rel="noopener"
class="footer-link">Security</a></li>
<li class="mb-2"><a
href="https://www.apache.org/events/current-event.html"; target="_blank"
rel="noopener" class="footer-link">Events</a></li>
<li class="mb-2"><a
href="https://www.apache.org/foundation/sponsorship.html"; target="_blank"
rel="noopener" class="footer-link">Sponsorship</a></li>
<li class="mb-2"><a
href="https://www.apache.org/foundation/thanks.html"; target="_blank"
rel="noopener" class="footer-link">Thanks</a></li>
- <li class="mb-2"><a href="/privacy-policy.html"
class="footer-link">Privacy Policy</a></li>
+ <li class="mb-2"><a
href="https://privacy.apache.org/policies/privacy-policy-public.html";
target="_blank" rel="noopener" class="footer-link">Privacy Policy</a></li>
Review Comment:
The footer now links to the canonical ASF privacy policy, but the site still
hosts an internal `/privacy-policy.html` page (and it’s listed in
`sitemap.xml`). This can confuse users and may still fail ASF/Whimsy checks if
project-specific privacy policy pages are not allowed. Consider either removing
`/privacy-policy.html` (and its sitemap entry) or turning it into a simple
redirect/notice that points to
`https://privacy.apache.org/policies/privacy-policy-public.html`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
