sergehuber opened a new pull request, #858:
URL: https://github.com/apache/unomi/pull/858

   ## Summary
   - Follow-up to #843. `SubscriptionWebSocketFactory` is only ever handed to 
Jetty as the socket creator and is never started or stopped as a lifecycle, so 
the `doStop()` override that was meant to stop its deadline scheduler never ran 
and the scheduler thread outlived each servlet instance.
   - Shut the scheduler down explicitly from `GraphQLServlet.destroy()`, via an 
explicit `shutdown()` on the creator, instead of relying on a lifecycle hook 
that is never invoked.
   
   ## Test plan
   - [x] New 
`SubscriptionWebSocketFactoryTest.shutdown_stopsTheDeadlineScheduler`; 
`cxs-impl` unit tests green locally (57)
   - [ ] CI
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to