jsinovassin opened a new pull request, #862:
URL: https://github.com/apache/unomi/pull/862

   [UNOMI-981](https://issues.apache.org/jira/browse/UNOMI-981)
   
   ### What this changes
   
   The `package` module deploys its distribution again. The dummy jar takes the 
classifier `buildcache`, and the blanket `maven-deploy-plugin` skip is dropped.
   
   ### Evidence
   
   The last published distribution snapshot is 
`unomi-3.1.0-20260602.094524-27.tar.gz`, from 2026-06-02. Every other module 
kept publishing, and `unomi-services` is at build 65 from 2026-09-04.
   
   Commit `02ab3c670`, from 2026-06-06, added this:
   
   ```xml
   <!-- Ensure the dummy jar is NOT deployed -->
   <plugin>
       <artifactId>maven-deploy-plugin</artifactId>
       <configuration>
           <skip>true</skip>
       </configuration>
   </plugin>
   ```
   
   The comment names the dummy jar, and the setting skips the whole module. The 
tar.gz and the zip went with it.
   
   ### Mechanism
   
   The dummy jar carries no classifier, and this module is packaged as a `pom`. 
The jar plugin therefore makes that jar the artifact of the module, which is 
what the skip was added to hide. A classifier keeps the jar a side artifact, so 
the skip is no longer needed.
   
   ### Effect
   
   `mvn deploy` against a local repository now deposits four files for this 
module:
   
   ```
   unomi-3.1.0-SNAPSHOT.pom
   unomi-3.1.0-SNAPSHOT.tar.gz
   unomi-3.1.0-SNAPSHOT.zip
   unomi-3.1.0-SNAPSHOT-buildcache.jar
   ```
   
   ### Notes for the reviewer
   
   Every change made under `package/src/main/resources/etc/` since 2026-06-06 
is missing from the published distribution. A downstream build unpacks that 
distribution, as Jahia jCustomer does, and ships a `custom.system.properties` 
that carries none of the 3.1 authentication settings.
   
   I verified the deployment against a local repository, and not against a real 
snapshot repository.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to