jsinovassin opened a new pull request, #869: URL: https://github.com/apache/unomi/pull/869
Fixes UNOMI-987, at https://issues.apache.org/jira/browse/UNOMI-987 ### What this changes `bom/artifacts/pom.xml` lists `unomi-plugins-advanced-conditions`, next to the four plugins it already carries. ### Evidence A downstream build that imports the BOM could not declare that dependency. Maven refused to read the project: ``` [ERROR] 'dependencies.dependency.version' for org.apache.unomi:unomi-plugins-advanced-conditions:jar is missing. ``` UNOMI-875 created `plugins/advanced-conditions` and moved `sourceEventPropertyCondition` into it, at https://github.com/apache/unomi/pull/774. The BOM was not updated in the same change. The BOM listed four plugins: `unomi-plugins-base`, `unomi-plugins-request`, `unomi-plugins-mail` and `unomi-plugins-optimization-test`. ### Mechanism The module is a bundle, and `distribution/src/main/feature/feature.xml` names it in four places, so a downstream distribution has a reason to depend on it. Only the BOM entry was absent. ### Notes for the reviewer Two more bundle modules carry no BOM entry, `unomi-plugins-hover-event` and `unomi-plugins-tracked-event`. This pull request leaves them alone. Neither is named in the distribution feature, so their absence may be deliberate, and the decision belongs to a maintainer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
