Jonathan Sinovassin-Naïk created UNOMI-987:
----------------------------------------------
Summary: The BOM does not list unomi-plugins-advanced-conditions
Key: UNOMI-987
URL: https://issues.apache.org/jira/browse/UNOMI-987
Project: Apache Unomi
Issue Type: Bug
Reporter: Jonathan Sinovassin-Naïk
{{bom/artifacts/pom.xml}} does not list {{unomi-plugins-advanced-conditions}}.
A downstream build
that imports the BOM cannot declare that dependency, and Maven refuses to read
the project:
{noformat}
[ERROR] 'dependencies.dependency.version' for
org.apache.unomi:unomi-plugins-advanced-conditions:jar
is missing.
{noformat}
The module is a bundle, and the distribution feature declares it, so a
downstream distribution has a
reason to depend on it. Only the BOM entry is absent.
h2. Where the gap comes from
[UNOMI-875|https://issues.apache.org/jira/browse/UNOMI-875] created
{{plugins/advanced-conditions}} and moved {{sourceEventPropertyCondition}} into
it, at
[apache/unomi#774|https://github.com/apache/unomi/pull/774]. The BOM was not
updated in the same
change.
{{bom/artifacts/pom.xml}} lists four plugins:
* {{unomi-plugins-base}}
* {{unomi-plugins-request}}
* {{unomi-plugins-mail}}
* {{unomi-plugins-optimization-test}}
{{distribution/src/main/feature/feature.xml}} names
{{unomi-plugins-advanced-conditions}} in four
places, so the module is part of the shipped distribution.
h2. Steps to reproduce
# Build a project that imports {{org.apache.unomi:unomi-bom}} with scope
{{import}}.
# Declare a dependency on
{{org.apache.unomi:unomi-plugins-advanced-conditions}} with no version.
# Run {{mvn validate}}.
h2. Expected result
The BOM supplies the version, as it does for the other four plugins.
h2. Actual result
Maven cannot read the project, and the build stops before it compiles anything.
h2. Proposed fix
Add the entry to {{bom/artifacts/pom.xml}}, next to the four plugins already
listed:
{code:xml}
<dependency>
<groupId>org.apache.unomi</groupId>
<artifactId>unomi-plugins-advanced-conditions</artifactId>
<version>${project.version}</version>
</dependency>
{code}
h2. Other bundles absent from the BOM
A comparison of the module tree against {{bom/artifacts/pom.xml}} names two
more bundle modules with
no BOM entry:
* {{unomi-plugins-hover-event}}
* {{unomi-plugins-tracked-event}}
This report does not claim those two are defects. Neither is named in the
distribution feature, so
their absence may be deliberate. They are listed here so that one decision can
cover all three.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
