sergehuber commented on PR #861: URL: https://github.com/apache/unomi/pull/861#issuecomment-5732311055
Thank you for this, Jonathan — it is a really helpful piece of 3.1 migration work, and I am grateful you took the time to make compatibility mode actually usable for 2.x / 3.0 clients. `getOrCreateTenant` is the right idea: a legacy client cannot name a tenant, so this mode should create `default` rather than answering 401 until someone does it by hand. The create / re-read race handling looks solid, and renaming `v2.compatibilitymode.enabled` to `singletenantcompatibility.enabled` is a nice clarity improvement while 3.1 is still unreleased. CI looking green is much appreciated as well. One small docs follow-up, if you have a moment — happy to help with the wording if useful. The code now hard-codes tenant `default` and drops `v2.compatibilitymode.defaultTenantId`, but `migrate-3.0-to-3.1.adoc` and `v2-compatibility-mode.adoc` still tell operators to set `v2.compatibilitymode.tenantId`. That setting will no longer do anything, so people following the guide could think they had configured a tenant when they had not. The same pass on leftover `UNOMI_REST_AUTHENTICATION_V2COMPATIBILITYMODE*` environment names versus the new `SINGLETENANTCOMPATIBILITY` form would save operators a hunt. Thank you again for this. Happy to merge as soon as the docs match the code, and please do keep the PRs coming. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
