sergehuber commented on PR #864: URL: https://github.com/apache/unomi/pull/864#issuecomment-5732312143
Thank you for this, Jonathan — this is an important 3.1 regression fix and I am really glad you found it. Optional `parameter::` values that are absent turning into `field == null` (and then failing the whole `and` condition) would quietly stop rules such as `copyURLParams` and page-view counting. Distinguishing “unset optional parameter” (`UNRESOLVABLE`) from “resolved to null” is a careful restoration of the 2.x “drop this clause” behaviour, without undoing UNOMI-883. Using identity comparison against the sentinel is the right way to read it. CI is green, including the ITs, which is much appreciated. I am happy to merge this. Thank you for taking the time — contributions like this help a lot, and they are very welcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
