sergehuber commented on PR #865:
URL: https://github.com/apache/unomi/pull/865#issuecomment-5856152282

   The integration test was still describing the old behaviour: it saved a 
profile with no `itemId` and then read the first search hit. `saveOrMerge` now 
returns null and writes nothing, so that read threw `IndexOutOfBoundsException` 
on an empty page.
   
   `ProfileServiceIT.testProfileWithoutItemId` now asserts that `saveOrMerge` 
returns null, and that a search for that name stays empty for the same window a 
successful save would have become visible in. That is the only change on top of 
your commit (`ddcf7a151`).
   
   The persistence guard and the profile endpoint stay as you wrote them. A 400 
on Session and Persona create can be a follow-up; a persistence-level refusal 
is enough for this pull request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to