[
https://issues.apache.org/jira/browse/UNOMI-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18137115#comment-18137115
]
Serge Huber commented on UNOMI-1023:
------------------------------------
Fixed in tracker 2.0.0 (https://github.com/apache/unomi-tracker/pull/28) and
1.6.0 (https://github.com/apache/unomi-tracker/pull/29), both merged. The
browser build now runs without a Buffer polyfill; the server tests check it
against every Unomi version.
> Websites that load the Unomi tracker file directly get no tracking at all
> -------------------------------------------------------------------------
>
> Key: UNOMI-1023
> URL: https://issues.apache.org/jira/browse/UNOMI-1023
> Project: Apache Unomi
> Issue Type: Bug
> Components: unomi-tracker
> Affects Versions: unomi-tracker-1.5.0
> Reporter: Serge Huber
> Assignee: Serge Huber
> Priority: Major
> Fix For: unomi-tracker-1.6.0, unomi-tracker-2.0.0
>
>
> h3. Summary
> Websites that load the published tracker file directly get no tracking at
> all, and nothing tells the site owner. The tracker bundled with Unomi is not
> affected.
> Technical detail: the UMD build throws "Buffer is not defined" in browsers,
> because es6-crawler-detect calls Buffer.byteLength. Also true of 1.5.0 and of
> es6-crawler-detect 4.x.
> h3. Approach
> * When Buffer exists, call the library as today.
> * Otherwise, give it a Buffer.byteLength for that one synchronous call;
> nothing is left on window.
> * No library upgrade on 1.x.
> h3. How to test
> * Unit tests: same byte count as Buffer.byteLength, same result with and
> without Buffer.
> * yarn test:servers: works without a polyfill; requests identical to 1.5.0.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
