[ 
https://issues.apache.org/jira/browse/UNOMI-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18137188#comment-18137188
 ] 

Serge Huber commented on UNOMI-1037:
------------------------------------

The first fix only covered sendClickEvent used as an event listener. A site 
that passes a success or error callback was still losing every second click: 
with a callback, the tracker does not dispatch the click again, so the element 
was only forgotten on the next click. The tracker now forgets it as soon as the 
event is sent, before calling the callback. Both ways are tested against each 
Unomi server (three clicks, three stored events): 
https://github.com/apache/unomi-tracker/pull/39

> Tracker: only the first click on a link or button is tracked
> ------------------------------------------------------------
>
>                 Key: UNOMI-1037
>                 URL: https://issues.apache.org/jira/browse/UNOMI-1037
>             Project: Apache Unomi
>          Issue Type: Bug
>          Components: unomi-tracker
>            Reporter: Serge Huber
>            Assignee: Serge Huber
>            Priority: Major
>             Fix For: unomi-tracker-1.6.0, unomi-tracker-2.0.0
>
>
> When a website sends clicks with sendClickEvent (directly, or for the links 
> and buttons Unomi tracks with clickOnLinkEventCondition), only the first 
> click on each element is sent to Unomi. Later clicks on the same element, on 
> the same page, are never sent, so rules and statistics based on them miss 
> data.
> Cause: sendClickEvent remembers the element while its click is re-dispatched, 
> and should forget it afterwards, but uses {{splice(eventIndex, 0)}}, which 
> removes nothing.
> Fix: {{splice(eventIndex, 1)}}. Covered by a browser test against each Unomi 
> server (two clicks, two stored events).



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to