sergehuber opened a new pull request, #41: URL: https://github.com/apache/unomi-tracker/pull/41
## Summary The click and form tracking fixes of #39, for tracker 1.6.0, with their browser tests. As in #29, `dist` is not rebuilt. - **UNOMI-1037**: every click on a tracked link or button is tracked, not only the first one, also a second click made before the first event is sent. - **UNOMI-1040**: links and forms work at once when Unomi cannot be reached or tracking is off; without a timeout, they wait 1.5s at most. - **UNOMI-1041**: Ctrl or Cmd+click opens a new tab, and is still tracked. - **UNOMI-1042**: a tracked form is submitted with the button that was used. - **UNOMI-1043**: without a usable `timeoutInMilliseconds`, the default of 1500 ms is used, instead of every request failing at once. - **UNOMI-1046**: the site's own click handlers run once per click. - **UNOMI-1047**: a click inside a tracked link or button is tracked on it. - **UNOMI-1038**: `sourceLocalIdentifierMap` finds a mapped part anywhere in the id, also at its start. The tracker source is #39's, line for line, except what 1.x does not have: the type annotations and the defaults in the tracker object; it still exports `newTracker`. Left out, as 1.x does not have them: the Unomi 4, `apiKey` and `sendCredentials` tests, the server-test CI workflow and `.asf.yaml`, and the README sections on 2.x. Test setup: it now waits until the server answers steadily (5 checks in a row) before the tests, as on `main`. A starting Unomi 2.7 dropped its endpoints for a while, and the first tests failed with no context. ## Test plan - [x] `yarn lint`, `yarn test` - [x] `TRACKER_BROWSERS=chromium,firefox,webkit yarn test:servers`: the comparison with 1.5.0 (9), then Unomi 2.3, 2.7 and 3.0, 150 each, all passed - [ ] `yarn test:safari` on a Mac 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
