sergehuber opened a new pull request, #952:
URL: https://github.com/apache/unomi/pull/952

   ## Plain-language summary
   
   Admin tools and GraphQL used to tell any website that the browser may send 
the operator's login with the request. A page on another site could then read 
admin answers in the operator's browser. This change turns that off by default. 
An operator who runs the admin UI on another host can list that host so it 
still works.
   
   ## What changed
   
   * Admin REST endpoints no longer advertise credentialed CORS by default.
   * A new empty setting `org.apache.unomi.admin.cors.allowedOrigins` 
(`UNOMI_ADMIN_CORS_ALLOWED_ORIGINS`) lists the admin UI origins that may use 
credentials.
   * The existing CORS filter upgrades only those listed origins (same idea as 
the public tracker origin list).
   * GraphQL sends CORS headers with credentials only for listed origins; other 
cross-origin callers get no CORS grant.
   * Manual, migration guide, and threat-model notes describe the setting.
   
   ## Test plan
   
   * [x] `mvn -pl api,rest,web-servlets -am test 
-Dtest=PublicTrackerCorsFilterTest,AdminRestCorsTest,ShippedAdminCorsConfigTest,WebConfigTest,PublicTrackerCorsTest
 -Dsurefire.failIfNoSpecifiedTests=false`
   * [x] `mvn -pl graphql/cxs-impl -am compile -DskipTests`
   * [ ] CI on this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to