Ok, I've renamed a bunch of classes, should be more clear now (I hope)
On Thu, Nov 2, 2017 at 2:56 PM Serge Huber <[email protected]> wrote: > Ok thanks. Let us know when you're happy with the branch and I'll review > it. > > cheers, > Serge... > > Serge Huber > CTO & Co-Founder > T +41 22 361 3424 <+41%2022%20361%2034%2024> > 9 route des Jeunes | 1227 > <https://maps.google.com/?q=9+route+des+Jeunes+%7C+1227&entry=gmail&source=g> > Acacias | Switzerland > jahia.com <http://www.jahia.com/> > SKYPE | LINKEDIN <https://www.linkedin.com/in/sergehuber> | TWITTER > <https://twitter.com/sergehuber> | VCARD > <http://www.jahia.com/vcard/HuberSerge.vcf> > > > > JOIN OUR COMMUNITY <http://www.jahia.com/> to evaluate, get trained and > to discover why Jahia is a leading User Experience Platform (UXP) for > Digital Transformation. > > On Thu, Nov 2, 2017 at 2:52 PM, Thomas Draier <[email protected]> wrote: > > > Hi, > > > > I've created a PR : https://github.com/apache/incubator-unomi/pull/34 . > > You'll see it's only new code, it should be completely backward > compatible. > > > > It works with the example in the jira ticket. I'm not completely > satisfied > > with the class names though (some sort strategy do not sort anything, > just > > filter). Also I did not have the time to add the javadocs. I did the > > easiest part (code), still have to fix naming and doc before merge .. > > > > thomas > > > > > > On Thu, Nov 2, 2017 at 1:32 PM Jean-Baptiste Onofré <[email protected]> > > wrote: > > > > > It sounds good to me. What about creating a PR with a branch on your > > > GitHub ? > > > > > > Regards > > > JB > > > > > > On Nov 2, 2017, 12:06, at 12:06, Serge Huber <[email protected]> wrote: > > > >I like it ! Not sure if a branch is needed if it doesn't impact > > > >existing > > > >functionality. > > > > > > > >cheers, > > > > Serge... > > > > > > > >Serge Huber > > > >CTO & Co-Founder > > > >T +41 22 361 3424 <+41%2022%20361%2034%2024> > <+41%2022%20361%2034%2024> > > > >9 route des Jeunes | 1227 Acacias | Switzerland > > > >jahia.com <http://www.jahia.com/> > > > >SKYPE | LINKEDIN <https://www.linkedin.com/in/sergehuber> | TWITTER > > > ><https://twitter.com/sergehuber> | VCARD > > > ><http://www.jahia.com/vcard/HuberSerge.vcf> > > > > > > > > > > > >> JOIN OUR COMMUNITY <http://www.jahia.com/> to evaluate, get trained > > > >and > > > >to discover why Jahia is a leading User Experience Platform (UXP) for > > > >Digital Transformation. > > > > > > > >On Thu, Nov 2, 2017 at 10:50 AM, Thomas Draier <[email protected]> > > > >wrote: > > > > > > > >> Hi, > > > >> > > > >> I've created a ticket to get a new feature in unomi : > > > >> > > > >> https://issues.apache.org/jira/browse/UNOMI-134 > > > >> > > > >> Actually already implemented it, so would like to know what do you > > > >think > > > >> about the idea before pushing it in a branch :-) > > > >> > > > >> Regards > > > >> > > > > > >
