Github user michaelarusso commented on a diff in the pull request:
https://github.com/apache/usergrid/pull/544#discussion_r70094599
--- Diff:
stack/services/src/main/java/org/apache/usergrid/security/tokens/cassandra/TokenServiceImpl.java
---
@@ -789,12 +789,17 @@ MetricsFactory getMetricsFactory() {
}
- private boolean isExternalSSOProviderEnabled() {
+ public boolean isExternalSSOProviderEnabled() {
return Boolean.valueOf(properties.getProperty(
USERGRID_EXTERNAL_SSO_ENABLED ));
}
private String getExternalSSOProvider(){
- return properties.getProperty(USERGRID_EXTERNAL_PROVIDER);
+ try {
+ return properties.getProperty(USERGRID_EXTERNAL_PROVIDER);
+ }
+ catch(NullPointerException e ){
--- End diff --
I don't think this will throw an NPE as much as it would return ```null```
to the caller of ```getExternalSSOProvider()```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
