On Fri, Aug 29, 2014 at 2:53 AM, Lewis John Mcgibbney < [email protected]> wrote:
> Regardless of the answer to this question. I will review the RC and provide > my input. > > So I then unzip the .zip to find that the resulting artifact is actually > called apache-usergrid-incubating-1.0.0-rc3 > Is this an issue for you guys? I find this a bit strange. Does this cause > confusion for people further down the line? It is already causing confusion > for me right now. I am not really sure why it is not just called > apache-usergrid-incubating-1.0.0. The same is true for the tar.gz > This is a problem. I wanted the file to be named with the "rc3" designation, but not the actual artifact. > I then go in to portal and run ./build.sh e2e, this is what I get > > lmcgibbn@LMC-032857 > /usr/local/ug/apache-usergrid-incubating-1.0.0-rc3/portal(master) $ > ./build.sh e2e > ... > Done, without errors. > ./build.sh: line 31: webdriver-manager: command not found > to run e2e tests you need to have a running instance of webdriver, 1) npm > install protractor -g -> 2) webdriver-manager start --standalone > Running "connect:e2e-chrome" (connect) task > Started connect web server on 127.0.0.1:3006. > > Running "protractor:chrome" (protractor) task > Using the selenium server at http://localhost:4444/wd/hub > > > /usr/local/ug/apache-usergrid-incubating-1.0.0-rc3/portal/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1702 > throw error; > ^ > This is also a problem. Apparently, I did not run the Portal tests correctly. > I then go into /release, immediately I spot a sign-release.sh script. Is > this meant to be here? > > I run > lmcgibbn@LMC-032857 > /usr/local/ug/apache-usergrid-incubating-1.0.0-rc3/release(master) $ mvn > install > > I get a successful build however EVERYTHING is labelled as > apache-usergrid-incubating-1.0.0-rc3. > The sign-release.sh script should be there, but the rc3 designation should not. I then go into /sdks > Immediately I see a 'new' sdk usergrid-java-sdk-0.0.6 in addition to the > existing java sdk. is this meant to be here? > I install both Android and Java SDK... all OK. I am not going to try each > one... but this would be really helpful to see each one build and test > successfully. > The 0.0.6 SDK is required by the Android SDK, so instead of migrating the Android SDK to the latest Java SDK, I took the easy road and simply included 0.0.6 SDK source code. I then go into /stack > I go mvn clean install > One thing I notice about the build output is that it seems to be jam packed > with stack traces. So I file > https://issues.apache.org/jira/browse/USERGRID-222 > Eventually the build fails as follows > > ... > Tests in error: > OrganizationIT.testCreateOrganization:83 ยป UnconfirmedAdminUser > WTF. I was able to run the stack tests successfully before release. I wonder what went wrong. > I also find a rat.txt within /stack/target, is this meant to be here? > Yes, that is fine -- as long as the RAT report is clean. > I then dive into /ugc and execute gem install ugc > I can install it absolutely fine. I can then mess around and do stuff but I > haven't actually create an application that I can remeber so I stop there. > > Honestly, the main problem I have here is with item 2.1 on the checklist > [0]. This is of course > 2.1 Build is successful including automated tests. The expanded source > archive is expected to build and pass tests > <http://www.apache.org/dev/release.html#what-must-every-release-contain>. > I > am not sure that this is the case. Thanks for the in-depth review of the release candidate. I think we need to fix the test failures before we release, so at least one more RC will be necessary. - Dave
