Thanks Jason! I don't know PHP so I'm not the best person to review this pull request, but I did take a look. The project looks well-thought out and I did not see any red flags like binary files or missing headers.
Here's the PR: https://github.com/apache/incubator-usergrid/pull/88 Here are my questions for the team: 1) We already have a PHP SDK, how is this one different or better than what we have now? 2) This is a big contribution, assuming it looks good to others: should we simply pull it in to Usergrid master -- or do we need to do a code grant? 3) The files have an ASL license header and also a copyright by baas-platform.com. My understanding is that we do not require copyright assignment, so that's fine, no? Thoughts? Any PHP experts out there want to weigh in on this contribution? Who wrote our existing PHP SDK? Thanks, Dave On Sun, Oct 26, 2014 at 1:55 AM, apps4u <g...@git.apache.org> wrote: > Github user apps4u commented on the pull request: > > > https://github.com/apache/incubator-usergrid/pull/88#issuecomment-60507519 > > Added some more api operation descriptors to version 1.0.1 of this SDK > . It now has cleaner api and ResourceIteration as well. > >
