Github user apps4u commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/88#issuecomment-60871754
To answer question 3 , I know Im the author so I'm going to bias.
The current PHP SDK is not bad but their are the issues I ran into and why
I wrote this new SDK
1. the current SDK is hard to extend -- so If Usergrid changed or if I
added some custom API the the Usergrid rest module I'd have to changed the PHP
sdks to work with that. with the new SDK just create a new Guzzle Service
descriptor file (like swagger).
2 Its not easy to integrate with any of the current top PHP Frameworks
most top frameworks use Dependancy injection and IoC system and have ORM's with
the current PHP SDK it's not a easy task to integrate into the system.
3- Auth is not easy to changed on the fly and with the new SDK it support
all 4 level of Oauth2 Token and can take token that you may already have (e.g.:
pass token from javascript login to server side SDK).
4- versions Guzzle Web Service descriptors so as apache usergrid changes
or people add custom url routes to their version of Usergrid its as simple as
copying a PHP array and changing a few URI in the service descriptor no need
to be expert in php . This was one of the main reasons I wrote this Ive added
to Usergrid some custom tracking and a few new REST end points that I wanted to
be able use the PHP SDK with so using a system like PHP Guzzle removes the need
to make code changes just let the SDK take care of that and just create new
manifest files when need (Just like swagger in the api127 tool let the server
descriptor control access and uri).
October 29 2014 12:34 AM, "asfbot" wrote:
Â
Dave on [email protected]
(mailto:[email protected]) replies:
Thanks Jason!
I don't know PHP so I'm not the best person to review this pull request,
but I did take a look. The project looks well-thought out and I did not
see any red flags like binary files or missing headers.
Here's the PR: #88
(https://github.com/apache/incubator-usergrid/pull/88)
Here are my questions for the team:
1) We already have a PHP SDK, how is this one different or better than
what
we have now?
2) This is a big contribution, assuming it looks good to others: should
we
simply pull it in to Usergrid master -- or do we need to do a code grant?
3) The files have an ASL license header and also a copyright by
baas-platform.com (http://baas-platform.com). My understanding is that we
do not require copyright
assignment, so that's fine, no?
Thoughts?
Any PHP experts out there want to weigh in on this contribution? Who
wrote
our existing PHP SDK?
Thanks,
Dave
â
Reply to this email directly or view it on GitHub
(https://github.com/apache/incubator-usergrid/pull/88#issuecomment-60764744).
Â
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
