[
https://issues.apache.org/jira/browse/USERGRID-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347353#comment-14347353
]
ASF GitHub Bot commented on USERGRID-448:
-----------------------------------------
GitHub user snoopdave opened a pull request:
https://github.com/apache/incubator-usergrid/pull/173
Fix for USERGRID-448: Remove redundant appinfos collections in
ManagementServiceImpl
DO NOT MERGE
Needs careful review.
Changes to merge appinfo and application_info collections into one
application_info collection. Also:
- Removed unnecessary system and default applications
- Now use seek rather than search to load application info entities
- Uncommented the parts of ApplicationDeleteTest that did not work before
the appinfo fix
- Will migrate old appinfo collection to application_info on startup, but
can be configured to skip that
https://issues.apache.org/jira/browse/USERGRID-448
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/snoopdave/incubator-usergrid
USERGRID-448-appinfofix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-usergrid/pull/173.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #173
----
commit 67fe099a48b87d6becaae9b439a8d758efc314c4
Author: Dave Johnson <[email protected]>
Date: 2015-03-03T16:10:37Z
Implementation of AppDeleteTest and supporting REST test infra structure.
commit 485f5787056e25ce98b28821c52746766239bb81
Author: Dave Johnson <[email protected]>
Date: 2015-03-03T16:30:59Z
Removing redundant "appinfos" collection, work in progress.
commit 592c730232a5d5156b29c9644e2ed5873e829b7b
Author: Dave Johnson <[email protected]>
Date: 2015-03-03T17:46:31Z
Comment out parts of test blocked by USERGRID-448.
commit 6791df6d4037daadd2781d26ac14aa4a213bd3bd
Author: Dave Johnson <[email protected]>
Date: 2015-03-03T21:35:10Z
Move ApplicationInfo to Core package, use "application_info" type
consistently across entire codebase.
commit 3b91da08e9199356c3c62be54f47936ef8bb8ab5
Author: Dave Johnson <[email protected]>
Date: 2015-03-03T21:46:26Z
Merge branch 'two-dot-o' into USERGRID-361-appdeletetest
commit 4d8678cfdcb95f811bf7fe3b551a28be37ee76d9
Author: Dave Johnson <[email protected]>
Date: 2015-03-04T14:07:56Z
Merge branch 'USERGRID-361-appdeletetest' into USERGRID-448-appinfofix
Conflicts:
stack/rest/src/test/java/org/apache/usergrid/rest/test/resource2point0/endpoints/mgmt/ApplicationsResource.java
commit c0d50394e0e4f3b3669fcfd582b78ce49a86a542
Author: Dave Johnson <[email protected]>
Date: 2015-03-04T18:34:11Z
Changes to merge appinfo and application_info collections into one
application_info collection. Also:
- Removed unnecessary system and default applications
- Now use seek rather than search to load application info entities
- Uncommented the parts of ApplicationDeleteTest that did not work before
the appinfo fix
- Will migrate old appinfo collection to application_info on startup, but
can be configured to skip that
----
> Remove redundant appinfos collections in ManagementServiceImpl
> --------------------------------------------------------------
>
> Key: USERGRID-448
> URL: https://issues.apache.org/jira/browse/USERGRID-448
> Project: Usergrid
> Issue Type: Bug
> Components: Stack
> Reporter: David Johnson
> Assignee: David Johnson
> Fix For: 2.0
>
>
> There is a flaw in the two-dot-o CpEntityManagerFactory.
> The factory stores a collection of "appinfo" type entities, but the
> ManagementServiceImpl stores a redundant collection of "application_info"
> entities.
> The problem becomes evident when you try to delete an application. The
> application will only be deleted from the "appinfos" collection. When you
> call the management org/apps end-point you will still see the application
> because the end-point uses the "application_infos".
> To fix this:
> - Ensure that only one collection is stored
> - Add code to migrate the existing app information collections
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
