Github user snoopdave commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/173#issuecomment-77878271
Review notes
===
This is a big commit, so here are the key changes to consider. Many files
changed because I moved ApplicationInfo from the services module to the core
module, my IDE did some uncalled for formatting (removing trailing spaces) and
then I decided to move ApplicationInfo back home to services.
CpEntityManagerFactory
---
The main change here is that we no longer create an "appinfos" collection
and instead rely solely on the "application_info" collection created by the
ManagementServiceImpl.
- System App and Default App have been removed completely, they were
unused
- No longer create redundant "organization" Entity
- New impl. of deleteApplication() that saves connections
- New impl. of restoreApplication() that restores connections
- lookupAppication(name) uses alias instead of ES
- migrationOldAppInfos() reads old "appinfo" entities and writes
"application_info" entities.
- New property usergrid.twodoto.appinfo.migration which defaults to true
JobServiceScheduler
---
- Fixes to adapt to new way MetricsFactory is instantiated. Somebody
changed it to be instantiated with Guice but did not fix this class.
ManagementServiceImpl
---
- New impl. of deleteApplication() that does some error checks and then
calls emf.deleteApplication()
- New impl. of restoreApplication() calls emf.restoreApplication(),
restores token and organization connection, and adds activity
ApplicationDeleteTest
---
- New and comprehensive app delete and restore tests
ApplicationsResource (test infrastructure)
---
- Represents management ApplicationsResource end-point
ManagementResponse (test infrastructure)
---
- Represents JSON response from management end-points
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
