[
https://issues.apache.org/jira/browse/VCL-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868153#comment-13868153
]
ASF subversion and git services commented on VCL-729:
-----------------------------------------------------
Commit 1557226 from [~arkurth] in branch 'vcl/trunk'
[ https://svn.apache.org/r1557226 ]
VCL-685
Added vcld -setup option to safely purge deleted and unused images from the
virtual disk datastore under some conditions.
Added the following subroutines to VMware.pm:
setup_get_menu
setup_vm_host_operations
setup_purge_datastore_images
get_datastore_image_names
Added the following subroutines to utils.pm:
get_array_intersection
get_imagerevision_cleanup_info
get_imagerevision_loaded_info
get_imagerevision_names
get_imagerevision_names_recently_reserved
get_imagerevision_reservation_info
get_management_node_vmhost_ids
Changed OS.pm::find_files. 3rd $search_type argument was not being used
anywhere. Changed it to $search_subdirectories. This is used by
get_datastore_image_names to speed up the search.
Added eval block to vSphere_SDK.pm::is_restricted to allow it to detect if the
SDK is not installed rather than always displaying a warning message.
Added optional vmhost_id argument to DataStructure.pm.
VCL-409
Replaced existing setup subroutines with a setup_get_menu subroutine in
image.pm and Module.pm. This allows multi-level menus to be defined by
constructing a hash. vcld retrieves the hash and presents the menu.
Added subroutines to utils.pm:
get_code_ref_package_name
get_code_ref_subroutine_name
get_management_node_vmhost_ids
setup_get_menu_choice
setup_print_break
Added check in State.pm::DESTROY to prevent warnings when running vcld -setup.
VCL-729
Added eval block in utils.pm::mail when Mail::Mailer is created. If sendmail
isn't installed this would generate an error which wasn't being caught in
vcld.log.
VCL-678
Changed several 'OK' notify messages to 'DEBUG' in VMware.pm and vSphere_SDK.pm.
> utils.pm::mail will display errors if $RETURNPATH is not defined
> ----------------------------------------------------------------
>
> Key: VCL-729
> URL: https://issues.apache.org/jira/browse/VCL-729
> Project: VCL
> Issue Type: Bug
> Components: vcld (backend)
> Affects Versions: 2.3.2
> Reporter: Andy Kurth
> Assignee: Andy Kurth
> Priority: Minor
> Fix For: 2.3.3
>
>
> utils.pm::mail isn't checking if $RETURNPATH is defined before passing it as
> an argument to Mail::Mailer. If not defined, an error is generated in
> vcld.log and the email message isn't set. The argument is not required.
> $RETURNPATH should be checked. If not defined, don't pass it to Mail::Mailer.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
