[
https://issues.apache.org/jira/browse/VCL-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106852#comment-14106852
]
ASF subversion and git services commented on VCL-774:
-----------------------------------------------------
Commit 1619812 from [~acoburn] in branch 'vcl/trunk'
[ https://svn.apache.org/r1619812 ]
VCL-774
When using vSphere provisioning, the _get_file_info subroutine is unnecessarily
slow (measured in minutes rather than seconds) especially on systems with many
VMs (e.g. vCenter clusters). This is due to an overly comprehensive query
definition, when in fact only VmDiskFileQuery, FileQuery and FolderFileQuery
need to be used.
This commit eliminates the unnecessary query parameters.
> _get_file_info is unnecessarily slow for vSphere provisioning
> -------------------------------------------------------------
>
> Key: VCL-774
> URL: https://issues.apache.org/jira/browse/VCL-774
> Project: VCL
> Issue Type: Improvement
> Components: vcld (backend)
> Affects Versions: 2.3.2
> Environment: VMware vSphere
> Reporter: Aaron Coburn
> Labels: performance
> Fix For: 2.4
>
>
> The vSphere_SDK.pm:_get_file_info subroutine is unnecessarily slow on systems
> with large numbers of virtual machines (especially vCenter clusters).
> This is due to an overly comprehensive query definition in the
> HostDatastoreBrowserSearchSpec object.
> The query definition includes the following (around line 2483):
> VmDiskFileQuery->new(...),
> FileQuery->new(),
> FloppyImageFileQuery->new(),
> FolderFileQuery->new(),
> IsoImageFileQuery->new(),
> VmConfigFileQuery->new(),
> VmLogFileQuery->new(),
> VmNvramFileQuery->new(),
> VmSnapshotFileQuery->new()
> But in truth only the following are needed in the query:
> VmDiskFileQuery->new(...),
> FileQuery->new(),
> FolderFileQuery->new(),
> In my system, this drops the execution time of _get_file_info() from ~ 3.5
> minutes to ~ 5 seconds.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
