[ 
https://issues.apache.org/jira/browse/VCL-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14195027#comment-14195027
 ] 

ASF subversion and git services commented on VCL-759:
-----------------------------------------------------

Commit 1636429 from [~jfthomps] in branch 'vcl/trunk'
[ https://svn.apache.org/r1636429 ]

VCL-759 - check user group access to image when creating block allocations

updated so that only admins are warned about user group not having access to 
image; also added warning for accepting block allocaitons (instead of just for 
creating new ones)

blockallocations.php:
-modified getPendingBlockHTML: added row for warning message; added onChange 
tag to user group selection to clear submitacceptcont2; added submitacceptcont2 
hidden input
-modified AJacceptBlockAllocationConfirm: added check for user group having 
access to image; added imageid to continuation data
-modified AJacceptBlockAllocationSubmit; get imageid and override from 
continuation data; added check for error having already been encountered before 
checking for empty set of management nodes; added overrideable check of user 
group having access to image; if user group does not have access to image, 
create a 2nd continuation that prevents the user group check from being done on 
the next submit
-modified processBlockAllocationInput: added conditional that $method must be 
new or edit to perform user group access to image check

blockallocations.js:
-modified acceptBlockConfirmCB: if warnmsg passed in, display it
-modified acceptBlockSubmit: if submitacceptcont2 is not empty, use that as the 
submitted continuation instead of the one from submitacceptcont
-modified clearCont2: added check for existance of submitcont2 before clearing; 
added conditional clearing of submitacceptcont2 as well

> check user group access to image when creating block allocations
> ----------------------------------------------------------------
>
>                 Key: VCL-759
>                 URL: https://issues.apache.org/jira/browse/VCL-759
>             Project: VCL
>          Issue Type: Improvement
>          Components: web gui (frontend)
>            Reporter: Josh Thompson
>             Fix For: 2.4
>
>
> When creating a block allocation, it would be useful to have a check to 
> ensure that the selected user group actually has access to the selected image 
> and warn the user if it does not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to