[
https://issues.apache.org/jira/browse/VCL-860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507634#comment-14507634
]
ASF subversion and git services commented on VCL-860:
-----------------------------------------------------
Commit 1675454 from [~arkurth] in branch 'vcl/trunk'
[ https://svn.apache.org/r1675454 ]
VCL-844
Added OS.pm::get_os_perl_package. Added Windows.pm::_get_os_perl_package which
is called by OS.pm::get_os_perl_package.
Updated OS.pm::get_os_type to return 'linux-ubuntu' if Ubuntu is detected
rather than just 'linux'.
Added generate_ssh_key_files,generate_ssh_public_key_string, and
create_ssh_public_key_file subroutines to OS.pm. These are used to facilitate
host to host copying of files for VM migrations.
Added hibernate subroutine to Linux.pm, Ubuntu.pm, Windows.pm, and Version_5.pm.
Added Windows.pm::enable_hibernation.
Added is_process_running and is_display_manager_running to Linux.pm. These are
used by Ubuntu.pm::hibernate to overcome issues which cause hibernation to fail.
Added subroutines to Ubuntu.pm to help overcome issues with hibernation:
* grubenv_unset_recordfail
* install_package
* _install_package_helper
* simulate_install_package
* apt_get_update
* fix_debconf_db
VCL-860
Updated Linux.pm::create_user to display a warning if any output line begins
with 'useradd:'.
> Linux.pm's create_user silently fails if vcl group does not exist
> -----------------------------------------------------------------
>
> Key: VCL-860
> URL: https://issues.apache.org/jira/browse/VCL-860
> Project: VCL
> Issue Type: Improvement
> Components: vcld (backend)
> Affects Versions: 2.4, 2.4.1, 2.4.2
> Reporter: Andy Kurth
> Priority: Minor
>
> The {{Linux.pm::create_user}} subroutine could be improved. If the *_vcl_*
> user group does not exist, {{create_user}} does not successfully create the
> user but returns true. No useful output is displayed in _vcld.log_
> indicating the user was not created. The following error message is being
> generated by the command but not being caught or displayed:
> {noformat}
> useradd: group 'vcl' does not exist
> {noformat}
> Later on, the following is displayed in _vcld.log_ when the code attempts to
> set the password of the non-existent user:
> {noformat}
> chpasswd: (user arkurth) pam_chauthtok() failed, error:
> Authentication token manipulation error
> chpasswd: (line 1, user arkurth) password not changed
> {noformat}
> This leads someone to try to troubleshoot a problem with the _passwd_
> command, even though the underlying problem is with sloppy code in
> {{create_user}}. This subroutine should be improved.
> Why is the *_vcl_* group even needed? This user group is not a default
> characteristic of the OS and is hard-coded in the VCL code -- something which
> should be avoided. It would simplify things if the default user group named
> after the user is used. If we add features in the future allowing more
> elaborate user groups to be configured, the *_vcl_* user group is going to
> continue to be a nuisance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
