[ 
https://issues.apache.org/jira/browse/VCL-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969843#comment-14969843
 ] 

ASF subversion and git services commented on VCL-909:
-----------------------------------------------------

Commit 1710097 from [email protected] in branch 'vcl/trunk'
[ https://svn.apache.org/r1710097 ]

VCL-909
Fixed minor bug in utils.pm::get_random_mac_address. It was selecting a random 
number from 0-255 inclusive. As a result, FF (256) was never chosen for a 
random MAC address. Changed to 0-256 inclusive.

VCL-910
Made minor, mostly cosmetic updates to utils.pm:
setup_get_hash_multiple_choice
setup_get_input_string
setup_print_wrap
setup_print_ok
setup_print_error
setup_print_warning

Other
Fixed badly named variables in add_imageid_to_newimages and added error output 
if the call failed.

> get_random_mac_address in utils.pm may generate the same mac for VMs
> --------------------------------------------------------------------
>
>                 Key: VCL-909
>                 URL: https://issues.apache.org/jira/browse/VCL-909
>             Project: VCL
>          Issue Type: Bug
>          Components: vcld (backend)
>    Affects Versions: 2.4.2
>            Reporter: Xianqing Yu
>
> We use get_random_mac_address() in libvirt.pm to generate random mac address 
> for VMs. However, we observe some of our reservations failed because some of 
> VMs have exactly the same mac (for both eth0 and eth1). Since reservations 
> are made by multiple users simultaneously, current design of 
> get_random_mac_address may return the same mac to multiple requests. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to