[
https://issues.apache.org/jira/browse/VCL-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929053#comment-15929053
]
ASF subversion and git services commented on VCL-1026:
------------------------------------------------------
Commit 1787263 from [email protected] in branch 'vcl/trunk'
[ https://svn.apache.org/r1787263 ]
VCL-1010
Added Windows 10 and 2016 keys to %VM_OS_CONFIGURATION in VMware.pm.
VCL-1026
Updated the default values in %VM_OS_CONFIGURATION from WinXPPro to windows7
and other to otherlinux. Also changed the associated default NIC and storage
models to the recommended defaults for the corresponding guestOS choice.
Added code to VMware.pm::capture to attempt to retrieve the OS product name and
architecture from the running VM before being shutting down. These values are
added to the VM's .vmx file after it is powered off, which in turn winds up in
the reference .vmx file.
Added VIM_SSH.pm::get_highest_vm_hardware_version_key. It queries the host's
capabilities and determines the highest VM virtual hardware version supported.
Added VIM_SSH.pm::get_supported_guest_os_ids. It also queries the host's
capabilities and generates a list of valid guestOS values. This is used to
verify a particular guestOS is supported. If not, a lesser default is used.
Updated VMware.pm::get_vm_virtual_hardware_version to call the API module's
get_highest_vm_hardware_version_key subroutine if implemented. This is used to
select the host's latest supported version.
Reworked VMware.pm::get_vm_guest_os to attempt to get both the guestOS and
newly added OS product name comment from the reference .vmx. If the product
name was retrieved, it attempts to figure out the best guest OS from it. If
not, it resorts to the guestOS value from the captured computer. If all else
fails, the default value from %VM_OS_CONFIGURATION is used.
Other
Updated experimental code to support VMware ESXi's built-in VNC server in
VMware.pm::node_status and prepare_vmx. All of this code is commented out.
> Improve VMware code's ability to select the proper guest OS
> -----------------------------------------------------------
>
> Key: VCL-1026
> URL: https://issues.apache.org/jira/browse/VCL-1026
> Project: VCL
> Issue Type: Improvement
> Components: vcld (backend)
> Reporter: Andy Kurth
> Assignee: Andy Kurth
> Fix For: 2.5
>
>
> VMware.pm currently selects the .vmx file's guestOS value by attempting to
> match the OS.name value to a hard-coded hash key in VMware.pm
> (%VM_OS_CONFIGURATION). If a base image is created for an OS not explicitly
> defined in the code, a very basic default is used (winXPPro or otherlinux).
> This works well enough for existing OS's. However, if you create a new
> Windows 10 base image and select the proper guestOS (windows9-64), VCL will
> resort to the XP default for images loaded with the image.
> It's worse for Linux images since most use the generic _vmwarelinux_ OS.
> Things could be easily improved by using the value from the reference .vmx
> file if available. This would the setting used to create a base image with
> the correct guestOS to be propagated to derivative VMs. It would not help
> existing images.
> Another option could be to attempt to determine the OS from the guest before
> an image is captured and include a comment in the reference .vmx file. This
> would allow guestOS's to be dynamically determined.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
