[ https://issues.apache.org/jira/browse/VCL-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943438#comment-15943438 ]
ASF subversion and git services commented on VCL-1029: ------------------------------------------------------ Commit 1788944 from [~jfthomps] in branch 'vcl/trunk' [ https://svn.apache.org/r1788944 ] VCL-1029 - add a section for managing affiliations to Site Configuration siteconfig.php: -modified generalOptions: added affiliation section to top of left column -modified timeSourceHTML, TimeVariable::getHTML, AffilTextVariable::getHTML, GlobalSingleVariable::getHTML, and GlobalMultiVariable::getHTML: changed object for siteconfigdesc from span to div -modified GlobalMultiVariable: added $addCBextra, $deleteCBextra, and $saveCBextra class variables -modified GlobalMultiVariable::__construct: set $type as $this->type; set default values for $addCBextra, $deleteCBextra, and $saveCBextra -modified GlobalMultiVariable::getHTML: added a div wrapper for everything after the h3 title with a class name of GMV{$this->domidbase}wrapper -modified GlobalMultiVariable::AJaddConfigMultiVal: changed extrafunc value from hard coded "addNewMultiValCBextra" to "$this->addCBextra" -modified GlobalMultiVariable::AJdeleteMultiSetting: changed call to deleteVariable to wrapper that calls $this->deleteValue that also checks for return value -added GlobalMultiVariable::deleteValue -modified GlobalMultiVariable::AJupdateAllSettings: if call to $this->validateValue returns false, also check for function having set a specific error message; added check for duplicate values being submitted; added check for nothing being changed and if so, return 'noaction' status; changed call to setVariable to call $this->updateValue instead; added extrafunc to returned data -added GlobalMultiVariable::updateValue -added Affiliations class that inherits from GlobalMultiVariable states.php: added $actions['classmapping']['affiliations'] = 'siteconfig'; siteconfig.js: -modified generalSiteConfigCB: added section to handle 'noaction' response status -modified GlobalMultiVariable.prototype.addNewMultiValCBextra: added missing semicolon after var func = this.deleteMultiVal -added GlobalMultiVariable.prototype.saveCBextra -added affiliation class and instantiation siteconfig.css: -modified ".configwidget h3": set margin-bottom to 0 -modified .siteconfigdesc: set top padding to 5px -added .GMVaffiliationwrapper -added #siteconfigconfirmoverlay -added #affiliationconfirmbox -added #affilconfirmname -added #affilconfbox-table -added #affilconfbox-cell > add a section for managing affiliations to Site Configuration > ------------------------------------------------------------- > > Key: VCL-1029 > URL: https://issues.apache.org/jira/browse/VCL-1029 > Project: VCL > Issue Type: Improvement > Components: web gui (frontend) > Reporter: Josh Thompson > Fix For: 2.5 > > > The database must be directly modified to add or remove affiliations. Admins > should not need to directly modify the database, especially for something as > simple as adding an affiliation. This can easily be added to the Site > Configuration page. -- This message was sent by Atlassian JIRA (v6.3.15#6346)