[
https://issues.apache.org/jira/browse/VCL-887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084873#comment-16084873
]
ASF subversion and git services commented on VCL-887:
-----------------------------------------------------
Commit 1801786 from [email protected] in branch 'vcl/trunk'
[ https://svn.apache.org/r1801786 ]
VCL-887
Swapped order of if/elsif section in utils.pm::run_ssh_command to prevent
unnecessary warnings in vcld.log when checking for SSH to respond.
> Clean up backend code
> ---------------------
>
> Key: VCL-887
> URL: https://issues.apache.org/jira/browse/VCL-887
> Project: VCL
> Issue Type: Improvement
> Components: vcld (backend)
> Reporter: Andy Kurth
> Assignee: Andy Kurth
> Fix For: 2.5
>
>
> Nearly all of the backend code is consistently formatted. For example:
> {code}
> if ($foo) {
> notify($ERRORS{'OK'}, 0, "some useful message");
> }
> else {
> notify($ERRORS{'WARNING'}, 0, "some useful warning");
> }
> {code}
> There is a space between _if_ and the opening parenthesis and another between
> the closing parenthesis and opening curly bracket. Compare it to:
> {code}
> if(!defined($du_output)) {
> notify($ERRORS{'WARNING'}, 0, "failed to execute command du command to if
> image $image_name exists");
> return;
> }
> {code}
> Where's the space? What does the message mean?
> Granted, the space issues are trivial. The nonsensical _notify_ message is a
> bit more of a problem.
> Perhaps we should create a script to analyze the code or even add a hidden
> option to _vcld_ to analyze itself. Committers could run it before
> committing to check for any accidental inconsistencies. We could add a step
> to the release procedures to run the script and check for inconsistencies.
> This issue will be used to track all of the code cleanup and of the
> development of any automated methods created to address this.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
